progress: false does not work in version 5.5.3

Version

v5.5.3

Reproduction link

https://codesandbox.io/s/8n6z6z30j8

Steps to reproduce

Add progress: false in request config:

this.$axios.get('URL', { progress: false });
this.$axios.post('URL', { data: 'data' }, { progress: false });

What is expected ?

progress bar is not displayed

What is actually happening?

Progress bar displayed for all types of requests (get, post, patch, delete)

Additional comments?

in version 5.3.6 it works correctly

<div align="right">_{This bug report is available on Nuxt community (#c255)}</div>

[daniluk4000]

Still not working in 5.6.0

[delanoflipse]

I did some digging and found that this might indeed be the result of an update in axios. But more in the sense that it shouldn’t have worked in earlier versions of this module.

When doing any axios request, axios creates a generic config file to create a request (see: https://github.com/axios/axios/blob/master/lib/core/mergeConfig.js)

It does not include the progress key. The axios onRequest hook that this module uses (see: https://github.com/nuxt-community/axios-module/blob/master/lib/plugin.js, line 108), expects that it does.

Creating a plugin as such:

$axios.onRequest(config => {
  console.log(config.progress);
});

Shows that it is always undefined (as could be expected), so the test config && config.progress === false always fails.

I was unable to find a way to pass custom data to the axios config as of yet. For now this ugly fix worked:

// https://github.com/nuxt-community/axios-module/blob/master/lib/plugin.js, line 108
axios.onRequest(config => {
  if (config && config.progress === false) {
    return;
  }

  if (config && config.headers && config.headers.__show_no_progress__ === true) {
    delete config.headers.__show_no_progress__;
    return;
  }

  currentRequests++;
});

// works with
$axios.$post(url, payload, { headers: { __show_no_progress__: true } });