Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Server side rendered locale switching links will always start with http

See original GitHub issue

Version

v5.2.1

Reproduction link

Steps to reproduce

What is expected ?

What is actually happening?

Additional comments?

In https://github.com/nuxt-community/nuxt-i18n/blob/e2aa687083873b6cb20b29beb044db8572e223cf/src/plugins/routing.js#L56 req.secure is used, which is only defined in Express, but SSR context only provides Node’s http.IncomingMessage which does not contain such property, resulting in any of the links generated by switchLocalePath server side to start with http.

<div align="right">_{This bug report is available on Nuxt community (#c128)}</div>

Issue Analytics

State:
Created 5 years ago
Comments:9 (2 by maintainers)

Top GitHub Comments

3reactions

pi0commented, Jun 17, 2019

Checking protocol can be easily done for this module:

https://github.com/nuxt-community/is-https

Which is already used by sitemap module

1reaction

rchlcommented, Jun 14, 2019

The logic is not that big (https://github.com/expressjs/express/blob/b8e50568af9c73ef1ade434e92c60d389868361d/lib/request.js#L306) but:

it requires external proxy-addr dependency
while in most cases it should do the right thing on its own, in specific setups users would need to provide configuration for that logic (same as trust proxy in expressjs provides here https://expressjs.com/en/4x/api.html#trust.proxy.options.table)

It feels kinda wrong to have to have all that in nuxt-i18n itself. It would be better if nuxt itself took care of those things. I wished nuxt used expressjs instead of connect…