Swagger 2.0 validation loop

Hi there,

I’m trying to build an sbt task to validate my swagger.json document against the 2.0 spec using fge/json-schema-validator

When I try to validate this example the validation fails with a validation loop error.

Here is an explanation by fge: https://groups.google.com/forum/#!msg/json-schema/UyM06JItXKQ/sS3PO6cWoK8J

If I’m not mistaken, there may be a significant flaw with the 2.0 spec (I haven’t checked 1.2)

This is how fge/json-schema-validator reports the error:

[error] com.github.fge.jsonschema.core.exceptions.ProcessingException: fatal: validation loop: schema "http://swagger.io/v2/schema.json#/definitions/primitivesItems/properties/type" visited twice for pointer "/paths/~1pets/get/parameters/0/items/type" of validated instance
[error]     level: "fatal"
[error]     schema: {"loadingURI":"http://swagger.io/v2/schema.json#","pointer":"/definitions/primitivesItems/properties/type"}
[error]     instance: {"pointer":"/paths/~1pets/get/parameters/0/items/type"}
[error]     domain: "validation"
[error]     alreadyVisited: "http://swagger.io/v2/schema.json#/definitions/primitivesItems/properties/type"
[error]     instancePointer: "/paths/~1pets/get/parameters/0/items/type"
[error]     validationPath: ["#","#/properties/basePath","#/properties/consumes","http://swagger.io/v2/schema.json#/definitions/mediaTypeList/items","#/properties/definitions","http://swagger.io/v2/schema.json#/definitions/definitions/additionalProperties","http://swagger.io/v2/schema.json#/definitions/schema/properties/properties","http://swagger.io/v2/schema.json#/definitions/schema/properties/properties/additionalProperties","http://swagger.io/v2/schema.json#/definitions/schema/properties/format","http://swagger.io/v2/schema.json#/definitions/schema/properties/type","http://json-schema.org/draft-04/schema#/properties/type/anyOf/0","http://json-schema.org/draft-04/schema#/properties/type/anyOf/1","http://swagger.io/v2/schema.json#/definitions/schema/properties/properties/additionalProperties","http://swagger.io/v2/schema.json#/definitions/schema/properties/type","http://json-schema.org/draft-04/schema#/properties/type/anyOf/0","http://json-schema.org/draft-04/schema#/properties/type/anyOf/1","http://swagger.io/v2/schema.json#/definitions/schema/properties/required","http://json-schema.org/draft-04/schema#/definitions/stringArray/items","http://json-schema.org/draft-04/schema#/definitions/stringArray/items","http://swagger.io/v2/schema.json#/definitions/definitions/additionalProperties","http://swagger.io/v2/schema.json#/definitions/definitions/additionalProperties","http://swagger.io/v2/schema.json#/definitions/schema/properties/properties","http://swagger.io/v2/schema.json#/definitions/schema/properties/properties/additionalProperties","http://swagger.io/v2/schema.json#/definitions/schema/properties/format","http://swagger.io/v2/schema.json#/definitions/schema/properties/type","http://json-schema.org/draft-04/schema#/properties/type/anyOf/0","http://json-schema.org/draft-04/schema#/properties/type/anyOf/1","http://swagger.io/v2/schema.json#/definitions/schema/properties/properties/additionalProperties","http://swagger.io/v2/schema.json#/definitions/schema/properties/type","http://json-schema.org/draft-04/schema#/properties/type/anyOf/0","http://json-schema.org/draft-04/schema#/properties/type/anyOf/1","http://swagger.io/v2/schema.json#/definitions/schema/properties/properties/additionalProperties","http://swagger.io/v2/schema.json#/definitions/schema/properties/type","http://json-schema.org/draft-04/schema#/properties/type/anyOf/0","http://json-schema.org/draft-04/schema#/properties/type/anyOf/1","http://swagger.io/v2/schema.json#/definitions/schema/properties/required","http://json-schema.org/draft-04/schema#/definitions/stringArray/items","http://json-schema.org/draft-04/schema#/definitions/stringArray/items","#/properties/host","#/properties/info","http://swagger.io/v2/schema.json#/definitions/info/properties/contact","http://swagger.io/v2/schema.json#/definitions/contact/properties/email","http://swagger.io/v2/schema.json#/definitions/contact/properties/name","http://swagger.io/v2/schema.json#/definitions/contact/properties/url","http://swagger.io/v2/schema.json#/definitions/info/properties/description","http://swagger.io/v2/schema.json#/definitions/info/properties/license","http://swagger.io/v2/schema.json#/definitions/license/properties/name","http://swagger.io/v2/schema.json#/definitions/license/properties/url","http://swagger.io/v2/schema.json#/definitions/info/properties/termsOfService","http://swagger.io/v2/schema.json#/definitions/info/properties/title","http://swagger.io/v2/schema.json#/definitions/info/properties/version","#/properties/paths","http://swagger.io/v2/schema.json#/definitions/paths/patternProperties/%5E~1","http://swagger.io/v2/schema.json#/definitions/pathItem/properties/get","http://swagger.io/v2/schema.json#/definitions/operation/properties/description","http://swagger.io/v2/schema.json#/definitions/operation/properties/operationId","http://swagger.io/v2/schema.json#/definitions/operation/properties/parameters","http://swagger.io/v2/schema.json#/definitions/parametersList/items","http://swagger.io/v2/schema.json#/definitions/parametersList/items/oneOf/0","http://swagger.io/v2/schema.json#/definitions/parameter/oneOf/0","http://swagger.io/v2/schema.json#/definitions/bodyParameter/properties/description","http://swagger.io/v2/schema.json#/definitions/bodyParameter/properties/in","http://swagger.io/v2/schema.json#/definitions/bodyParameter/properties/name","http://swagger.io/v2/schema.json#/definitions/bodyParameter/properties/required","http://swagger.io/v2/schema.json#/definitions/parameter/oneOf/1","http://swagger.io/v2/schema.json#/definitions/nonBodyParameter/oneOf/0","http://swagger.io/v2/schema.json#/definitions/headerParameterSubSchema/properties/collectionFormat","http://swagger.io/v2/schema.json#/definitions/headerParameterSubSchema/properties/description","http://swagger.io/v2/schema.json#/definitions/headerParameterSubSchema/properties/in","http://swagger.io/v2/schema.json#/definitions/headerParameterSubSchema/properties/items","http://swagger.io/v2/schema.json#/definitions/primitivesItems/properties/type","http://swagger.io/v2/schema.json#/definitions/headerParameterSubSchema/properties/name","http://swagger.io/v2/schema.json#/definitions/headerParameterSubSchema/properties/required","http://swagger.io/v2/schema.json#/definitions/headerParameterSubSchema/properties/type","http://swagger.io/v2/schema.json#/definitions/nonBodyParameter/oneOf/1","http://swagger.io/v2/schema.json#/definitions/formDataParameterSubSchema/properties/collectionFormat","http://swagger.io/v2/schema.json#/definitions/formDataParameterSubSchema/properties/description","http://swagger.io/v2/schema.json#/definitions/formDataParameterSubSchema/properties/in","http://swagger.io/v2/schema.json#/definitions/formDataParameterSubSchema/properties/items"]

Thoughts?

UPDATE Seems that the schema has a circular dependency: nonBodyParameter -> queryParameterSubSchema -> properties -> items -> primitivesItems -> items -> primitivesItems -> items -> primitiveItems ...

[fge]

The aforementioned issue is now fixed in version 2.2.6 (just published).

[luisobo]

Woah, that’s great. Thank you!