Stopping the server

First and foremost: keep up the good work, i like where this project is going (:

I tried to implement an fs.watch logic that restarts oak on file change. For this I added the AbortController as mentioned in the README and I added controller.abort() to my fs.watch. Unfortunately neither the promise from app.listen was ever resolved, nor was the underlying server closed - it also seems like server.close() is not called in https://github.com/oakserver/oak/blob/master/application.ts#L226

Do I misunderstand the idea behind the AbortController? Or is this just not fully implemented?

[kitsonk]

Yes, sorry folks. I think I fixed it in 4bc2c76cad7e3ffed3725e29dedbbd0d5b7e3925. It was a situation where it needed to process another request to actually close the server. I had run into an issue where if you were processing middleware (like you abort in middleware) it caused all sorts of carnage, so I didn’t do that, but then it did mean that it wouldn’t see that close until too late. Now it tracks if it handling requests, and if it isn’t it will close, which should resolve the promise, otherwise it will finish any in flight requests before closing. I need a better test “mock” as my current one is limited, and giving me a false sense of fixing the problem.

[acrodrig]

Quick question on this topic: why not just have an app.close method? It could encapsulate the abort controller and make it easy/easier to use.