Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Error with SOA type for Digital Ocean provider

See original GitHub issue

When I sync Digital Ocean DNS I get this error

Traceback (most recent call last):
  File "/Users/alex/.local/share/virtualenvs/dns-m997HFnd/bin/octodns-dump", line 10, in <module>
    sys.exit(main())
  File "/Users/alex/.local/share/virtualenvs/dns-m997HFnd/lib/python2.7/site-packages/octodns/cmds/dump.py", line 35, in main
    *args.source)
  File "/Users/alex/.local/share/virtualenvs/dns-m997HFnd/lib/python2.7/site-packages/octodns/manager.py", line 382, in dump
    source.populate(zone, lenient=lenient)
  File "/Users/alex/.local/share/virtualenvs/dns-m997HFnd/lib/python2.7/site-packages/octodns/provider/digitalocean.py", line 231, in populate
    data_for = getattr(self, '_data_for_{}'.format(_type))
AttributeError: 'DigitalOceanProvider' object has no attribute '_data_for_SOA'

After seeing code I see that it doesn’t support SOA type but instead of just ignore it, code crash, how can we patch it ?

Adding a check to know if attribute exist here seems to be a good solution is it okay for you ?

Issue Analytics

State:
Created 4 years ago
Comments:7 (3 by maintainers)

Top GitHub Comments

1reaction

jamiewebcommented, Jul 13, 2019

Thanks @ross, I have an article about using OctoDNS with DigitalOcean ready to publish, so I’m just waiting on this bug to be fixed in the Python pip package before I can publish it.

1reaction

rosscommented, Jul 13, 2019

No specific plans to cut a release atm, but I’ll throw it onto the todo list.