Lots of provider modules tests failing post v0.9.16

Started seeing failures when manually working so I created a new manually runnable action that runs the test suites of all the modules in https://github.com/octodns/octodns/pull/883.

Result is a lot of copy-n-pasted failures due to the fact that Zone.changes no longer excludes root NS records with the _is_eligible filter function.

This is fine in terms of it’s not an actual breakage of any real-world use of octoDNS. It’s also something that the work in https://github.com/octodns/octodns/pull/883 is designed to surface earlier…

            zone = Zone('unit.tests.', [])
            provider.populate(zone)
            self.assertEqual(19, len(zone.records))
            changes = expected.changes(zone, provider)
>           self.assertEqual(0, len(changes))
E           AssertionError: 0 != 1

I think the fix here will just be to go through and update all the tests to handle this case. It’s not ideal, but it’s probably the best option.

/cc https://github.com/octodns/octodns/runs/5482284584?check_suite_focus=true /cc https://github.com/octodns/octodns/pull/883

[ross]

Made a pass through all the modules updating all the requirements and making sure they’re passing with 0.9.16. PRs that do so are all linked up above. Will re-run the test suite once they’ve all been merged which should get things green.

[ross]

https://github.com/octodns/terraformed/pull/7 will fill out all the required contexts on repos which I believe should (additionally) force the modules tests to be manually run before merge. If/when we come up with or find a good way to trigger them at an appropriate point that would be even better.