Extended Proxy Support

I see #329 added proxy environment support but it is a very simple implementation that only handles https_proxy.

The person that maintains the proxy agent has an expanded version, https://github.com/TooTallNate/node-proxy-agent, which should do a better job of handling https_proxy and also no_proxy which isn’t currently being handled here.

Basic testing seems to show the following works as expected with the core octokit library, adding in proxy depending on both the https_proxy and no_proxy variables.

  const ProxyAgent = require('proxy-agent');

  const octokitProxy = new Octokit({
    request: { agent: new ProxyAgent()}
  })

[gr2m]

Okay I definitely want us to implement what is documented at https://docs.github.com/en/actions/hosting-your-own-runners/using-a-proxy-server-with-self-hosted-runners, and my understanding is that the current proxy agent we use does not take all 3 env variables into account, but proxy-agent does, so let’s use that 😃 We should also document it in the README and reference GitHub’s official docs.

Can you start a pull request?

[github-actions[bot]]

🎉 This issue has been resolved in version 3.15.7 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀