The arm64 image is missing in the docker tags

Hi,

I’d like to be able to run this on a rasberrypi. But there is no arm64 build. It looks like you are using a cross-compiler for go (xgo). it does have options to add arm64 (--targets=linux/arm64)

could it be as simple as this? .circleci/config.yml

//...
  build:
    executor: python
    working_directory: ~/offen
    environment:
      DOCKER_LOGIN: offen
      DOCKER_BUILDKIT: '1'
    steps:
      - checkout
      - setup_remote_docker:
          version: 20.10.6
      - run:
          name: Set revision
          command: |
            if [ -z "$CIRCLE_TAG" ]; then
              echo 'export OFFEN_GIT_REVISION=$(git rev-parse --short HEAD)' >> $BASH_ENV
            else
              echo 'export OFFEN_GIT_REVISION=$CIRCLE_TAG' >> $BASH_ENV
            fi
      - run:
          name: Build binaries
          command: |
            if [ -z "$CIRCLE_TAG" ] && [ "${CIRCLE_BRANCH}" != "development" ] && [ "${CIRCLE_BRANCH}" != "master" ]; then
              make build
            else
---           TARGETS=linux/amd64,windows/amd64 make build
+++           TARGETS=linux/amd64,windows/amd64,linux/arm64 make build
              # Darwin builds cannot be statically linked right now
              # so we override the default LDFLAGS value
              TARGETS=darwin/amd64 LDFLAGS='' make build
            fi
      - persist_to_workspace:
          root: ~/offen
          paths:
            - bin/*
//...

Would love to hear your thoughts on this

[strootje]

Yes! My pi4 can easily pull a arm64 image now. Thanks for the guidance and the quick responses. They really made this a lot easier 👍

[strootje]

xgo is used because Offen uses go-sqlite which uses CGO which means you need a platform-specific C toolchain (yay for acronyms) if you want statically linked binaries. The go tool would only let you build dynamically linked ones when you need to use CGO.

Thanks for the explanation.

I’ll have a look at docker buildx in the morning