SQL Migrations Not Working?

So I know you wrote a test to test that ported sqlite migration code, saw that test in one of your commits. But when I try this in my app, it’s simply not working:

InMemoryDB.ts

const inMemoryDb = newDb();
inMemoryDb.public.none(fs.readFileSync(path.resolve(__dirname, 'migrations/001-initial.sql'), 'utf8'));
(async () =>await inMemoryDb.public.migrate())();
const skills = inMemoryDb.public.many("select * from skills where name = 'Swift'");
console.log('skills', skills); // prints []

the migrations folder is at the same level as InMemoryDB.ts and in that folder is:

001-initial.sql
002-add-skills.sql

001-initial.sql - definitely adds a skills table seeded with some initial skills

002-add-skills.sql

INSERT INTO skills VALUES ('Swift', 0);
INSERT INTO skills VALUES ('Objective-C', 0);

no idea here, thoughts?

[oguimbal]

Tests

Some kind of building (transpiling, actually) is necessary given that it’s TS, so no, it is not possible to run mocha directly on ts files. When you do that on your side, I suppose that you’re using ts-node or something equivalent, which is transpiling TS for you. That’s also what does Webpack. Kind of an equivalent way to do the same thing.

Moreover, the current setup of pg-mem tests is using webpack because it’s way faster to code that way for me. That’s a matter of choice.

Ts compilation error

I dont see this problem on my side …

[oguimbal]

No need to read 001-initial.sql, the migration will do that for you.

Moreover, the line (async () =>await inMemoryDb.public.migrate())(); is effectively scheduling a migration, but triggers it “for later” (it dettaches a promise… use a linter, and you will get a warning on this line). Dettached promises is a pattern that should be avoided as much as possible (and which is, in this case, the cause of your problem).

Thus, the 4th line is effectively executed BEFORE the migration.

This should work:

const inMemoryDb = newDb();
await inMemoryDb.public.migrate();
const skills = inMemoryDb.public.many("select * from skills where name = 'Swift'");
console.log('skills', skills);

You’ll have to execute this from an async method, though.