question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove requestFromBrowser settings from docs and config

See original GitHub issue

There is an old field from the Meteor version which seems to be left over in the docs and config files:

https://github.com/OHIF/Viewers/search?q=requestFromBrowser&unscoped_q=requestFromBrowser

Remove requestFromBrowser from all files. If it is the only field in the object requestOptions, remove the entire object from the config object.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
dannyrbcommented, Sep 18, 2019

If the web client makes web request to a PACS located at a different host/domain, you will need to address CORS

0reactions
dannyrbcommented, Sep 18, 2019

Correct. With v1 you could proxy requests to the PACs and avoid CORS errors. We don’t have a way to sidestep this issue now that the OHIF Viewer doesn’t have a server side component.

Most PACS do not recommend exposure to the open web. You can see how we use nginx to reverse proxy requests in one of our deployment recipes – most web servers support this feature. In our recipe, because the DICOMWeb endpoints and the web client share the same origin, no CORS headers are needed.

We’re aware that CORS is a common pain point for our users. It’s a bit tricky, as there’s no good silver bullet for all of the potential setups, and we’re trying to avoid the maintenance burden (and security issues) a proxy can cause. Even education is a bit difficult as the bulk of our users have limited experience with stuff like this.

If you have any recommendations, we’re definitely all ears. As is, I point people to our recipes and hint that they may need to reach out to a consultancy.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Stop managing or delete Chrome browsers - Google Support
Windows. To remove Chrome browser management policies from a Windows device, you need to clear the Chrome registry settings and then restart Chrome...
Read more >
Network features reference - Chrome Developers
To manually clear the browser cache at any time, right-click anywhere in the Requests table and select Clear browser cache.
Read more >
Delete cookies in Microsoft Edge
Delete all cookies · In Edge, select Settings and more in the upper right corner of your browser window. · Select Settings >...
Read more >
Setting up Postman
Remove tabs - Postman web app only. · Two-pane view - By default, Postman displays responses below requests. · Show icons with tab...
Read more >
Promise based HTTP client for the browser and node.js - GitHub
Example; Axios API; Request method aliases; Concurrency; Creating an instance; Instance methods; Request Config; Response Schema; Config Defaults.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found