[Thumbnail Series] issues with scrolling list

Bug Report

Issue 1: Mouse wheel not scrolling thumbnail list on Series panel

If user isn’t placing the mouse cursor on a thumbnail, the mouse wheel won’t scroll the thumbnail list.

Expected Result:

1. Mouse wheel should scroll the thumbnail list when mouse cursor is placed anywhere inside the Series panel, not only on the thumbnail.

Issue 2: Arrows UP and DOWN scrolls thumbnails after drag-n-drop

If user drags a new thumbnail into the viewport and tries to navigate between the study frames with Arrow Up and Down, the thumbnail list will also scroll.

Steps to reproduce:

1. Open Patient Study MISTER^MR
2. Press hotkeys ARROW UP and ARROW DOWN
3. Verify that you will navigate in the study frames
4. Drag-and-drop the second thumbnail into the viewport
5. Press hotkeys ARROW UP and ARROW DOWN
6. Verify that you will navigate in the study frames
7. Verify that Thumbnails list will be scrolled

Expected Result:

1. Thumbnails list should not be scrolled by hotkeys ARROW UP and ARROW DOWN

[dannyrb]

From my point of view, if the key is defined as a hotkey under user preferences, then it should not be able to scroll the thumbnail list.

If there is…

• A registered command
• Its bound hotkeys overlap a browser’s own shortcut/hotkey
• The command is “in context” and “should fire” if executed

Then… I would expect the browser’s own shortcut/hotkey to not fire (preventDefault)

These should be tested at: https://viewer-dev.ohif.org or on latest/master

[mirnasilva]

Thanks @dannyrb, That’s also my understanding. On master both issues were not reproducible. I’ll move forward and close this ticket.