question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Get rid of advanced config options

See original GitHub issue

From the beginning the separation of “simple” and “advanced” options felt wrong for me but some requirements wouldn’t be met without that. In case we can resolve #271 there is no actual need in other options to be in config.

  • gitDir should be resolved automatically. See #271
  • Deprecate subTaskConcurrency since it’s not safe to take any other value than 1
  • chunkSize can be set automatically depending on OS
  • concurrent can be deprecated since it is only misused ATM and make execution slower and there is no benefit in setting it
  • verbose should not be in config but a CLI argument IMO. Done in #344
  • globOptions is probably be coupled with each glob pattern separately and just go inside the single linter’s config after #273 is merged
  • ignore should be part of each glob pattern somehow. See https://github.com/okonet/lint-staged/pull/273#issuecomment-330183246

This would allow simplifying the configuration and validation of user configs and make it even more easier to use.

Any thoughts?

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:4
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
okonetcommented, Jul 2, 2019

I have been running eslint, prettier, tslint and many other linters in parallel without issues for years now so I’m wondering why are you having them. Concurrent was only set to the different globs and was always false for the same glob. The only scenario where I could imagine collisions is when your globs match same files.

1reaction
okonetcommented, Sep 14, 2017

Why don’t we support it both as CLI argument and also in the config file?

because this will require to keep the advanced config which I want to drop. Also feels wrong from the UI perspective: verbose mode is intended to be used when something doesn’t work as supposed and not something you configure to run all the time.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Access and Change Hidden Advanced Settings in ...
To access the hidden advanced settings in Chrome, type: chrome://flags in the address bar and press Enter. The list of available settings ......
Read more >
How to delete a vCenter Server advanced setting | Yellow Bricks
How to delete a vCenter Server advanced setting · SSH to you vCenter Server · Go to the “shell” · go to director:...
Read more >
How to change or reset an advanced setting in Firefox
1. The more advanced settings for Firefox are only available by visiting a special url. Start by clicking into the Address Bar at...
Read more >
Configuring advanced options for ESXi/ESX (1038578)
Under the System heading, click Advanced System Settings. Settings are listed alphabetically by name similar to SectionName.OptionName . ( ...
Read more >
All Advanced Configuration Options - Parsec
The advanced settings are available through configuration files on both the host and the client, and allows for some settings not shown via...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found