Pre-commit hook runs for all files rather than only for those that are staged

I am using simple configuration via package.json:

"lint-staged": {
  "*.js": ["prettier --write", "eslint", "git add"]
 }

During commit of one file, prettier is run for all files (matching *.js) in my project rather then only for the file(s) being committed.

After execution of pre-commit hook, I see that hook did modifications in some files which are marked as unstaged by git. (Those files weren’t modified before commit)

Using:

husky 0.14.3
lint-staged 6.0.0
prettier 1.8.2

I didn’t hit this issue on different projects where we are using older version of lint-stage (v 5.0.0).

---

Console log:

[sudo-suhas]

The problem is here:

lint-staged Loaded scripts from package.json:
{ start: 'react-scripts start',
  build: 'react-scripts build',
  test: 'react-scripts test --env=jsdom',
  eject: 'react-scripts eject',
  'mock-api-server': 'nodemon mockApiServer/mockServer.js',
  precommit: 'lint-staged --debug',
  lint: 'eslint src/**/*.js',
  prettier: 'prettier --write \'src/**/*.{js,scss}\'',
  serve: 'npm run build && mkdir -p webroot/login2 && cp -R build/* webroot/login2/ && serve -s -p 4000 webroot/' }

You have a script named prettier which takes priority. You can also see this in the logs:

lint-staged:find-bin Resolving binary for command `prettier --write`
lint-staged:find-bin `prettier` resolved to npm script - `prettier --write 'src/**/*.{js,scss}'`

This gets executed using npm:

lint-staged:run-script bin: npm
lint-staged:run-script args: [ 'run',
  'prettier',
  '--',
  '--write',
  '/Users/matejprokop/dev/web-login/src/components/Content.js' ]

On the other hand, eslint and git are resolved correctly:

lint-staged:find-bin Resolving binary for command `eslint`
lint-staged:find-bin Binary for `eslint` resolved to `/Users/matejprokop/dev/web-login/node_modules/.bin/eslint`
...

So just rename your script to something like format and you should be good.

[sudo-suhas]

No problem. This behavior seems to trip quite a few people. We have been considering removing support for npm scripts or at least de-prioritizing it over installed binaries.