Question: Considering `.eslintignore`

Description

It sems that with this configuration:

"lint-staged": {
   "*.js": ["eslint --fix", "git add"]
}

eslint does NOT consider any .eslintignore, thus I get errors for files which are in folders that have an .eslintignore.

I have corrected this by doing this:

"lint-staged": {
   "*.js,.eslintignore": ["eslint --fix", "git add"]
}

Is this the correct way to configure this? Should this be a default behaviour? Maybe worth adding this to the example configs?

Thanks.

Steps to reproduce

Debug Logs

Environment

[kunalnagar]

@okonet I’m having a similar issue: I have an .eslintignore file.

1. If I run eslint on it’s own with --max-warnings 0, it respects the .eslintignore and I get no warnings

2. However, if I run the same command in lint-staged, it does not take into account the .eslintignore and throws the warnings

Here’s the command I’m running:

eslint --fix src/ --ext .ts --max-warnings 0

Here it is in lint-staged:

"lint-staged": {
    "*.md": [
      "prettier --parser markdown --write"
    ],
    "package.json": [
      "sort-package-json"
    ],
    "src/**/*.ts": [
      "prettier --write src/**/*.ts",
      "eslint --fix src/ --ext .ts --max-warnings 0"
    ]
  },

Here is the warning log when run from lint-staged:

/Users/kunalnagar/code/src/DefaultModel.ts
  0:0  warning  File ignored because of a matching ignore pattern. Use "--no-ignore" to override

/Users/kunalnagar/code/src/index.ts
  0:0  warning  File ignored because of a matching ignore pattern. Use "--no-ignore" to override

[jrozbicki]

For those traveling through the issues in future (like me for last couple hours):

@kunalnagar answer above was very helpful, but I had to adjust it to consider 2 .eslintrc configs I had (root and for cypress):

const { ESLint } = require('eslint')
const filterAsync = require('node-filter-async').default

// All of this below is caused by eslint dropping warnings (File ignored because of a matching ignore pattern.) on ignored files
// solution taken from: https://github.com/okonet/lint-staged#eslint--7

// two eslint initializations because we have two .eslintrc, one in root, another one in cypress/.eslintrc
const rootEslintCli = new ESLint()
const cypressEslintCli = new ESLint({ overrideConfigFile: './cypress/.eslintrc'})

const removeIgnoredFiles = async (files, eslintCli) => {
  const filteredFiles = await filterAsync(files, async (file) => {
    const isIgnored = await eslintCli.isPathIgnored(file)
    return !isIgnored
  })
  return filteredFiles.join(' ')
}

module.exports = {
  'src/**/*.{ts,tsx,js,jsx}': async (files) => {
    const filesToLint = await removeIgnoredFiles(files, rootEslintCli)
    return ['tsc', `eslint --fix --max-warnings=0 ${filesToLint}`]
  },
  'cypress/**/*.{ts,tsx,js,jsx}': async (files) => {
    const filesToLint = await removeIgnoredFiles(files, cypressEslintCli)
    return ['tsc --project cypress', `eslint --config cypress/.eslintrc --fix --max-warnings=0 ${filesToLint}`]
  },
}