Updating to lint-staged v9 issue -- using .eslintignore throws warnings!

Recently we’ve updated to use the latest version of eslint from v6. It appears that lint-staged no longer allows an advanced config. Instead of configuring lint-staged directly, you recommend using .prettierignore (or in our case .eslintignore) to ignore files.

Unfortunately this doesn’t work very well because with .eslintignore we get a warning in the console. Here’s what it looks like in my terminal:

git commit -am "test"
husky > pre-commit (node v10.16.3)
🔍  Finding changed files since git revision 200ebaddb.
🎯  Found 0 changed files.
✅  Everything is awesome!
  ↓ Stashing changes... [skipped]
    → No partially staged files found...
  ❯ Running tasks...
    ❯ Running tasks for client/**/*.js|server/src/**/*.js|e2e-tests/cypress/**/*.js
      ✖ eslint --rule 'react/jsx-curly-brace-presence: 1' --fix --max-warnings=0
        node addCopyright.js
        git add



✖ eslint --rule 'react/jsx-curly-brace-presence: 1' --fix --max-warnings=0 found some errors. Please fix them and try committing again.

/Users/tnrich/Sites/hde/server/src/data-lib/entities/aaSequence/countAASequence.js
0:0  warning  File ignored because of a matching ignore pattern. Use "--no-ignore" to override

✖ 1 problem (0 errors, 1 warning)

The crucial part is that warning File ignored because of a matching ignore pattern.. Lint staged now passes all the files eslint which is causing the ignore warning.

Not quite sure what to do here. Any suggestions @okonet ?

[okonet]

I don’t see the problem here. It works as expected so I’m not sure what’s this is about. We don’t change the behavior at any time.

[tnrich]

Thanks for the help @okonet not your fault. I think that eslint needs to add an option to not throw a warning if a file is ignored by .eslintignore but is specifically passed to eslint like eslint myIgnoreFile.js.

In the meantime I find that this is a decent workaround:

//lint-staged.config.js
const fs = require("fs");
const micromatch = require("micromatch");

const ignore = fs.readFileSync(".eslintignore", "utf8");
const lines = ignore.match(/[^\r\n]+/g);
const jsRunners = files => {
    const match = micromatch.not(files, lines);
    return match.map(
      file =>
        `eslint ${file} --rule 'react/jsx-curly-brace-presence: 1' --fix --max-warnings=0`
    );
  };

module.exports = {
  "client/**/*.js": jsRunners,
  "server/src/**/*.js": jsRunners,
  "e2e-tests/cypress/**/*.js": jsRunners,
  "tg-iso-lims/src/**/*.js|cypress/**/*.js": jsRunners,
  "*.css": ["node addCopyright.js", "git add"]
};