element-resize-detector not removed correctly on componentWillUnmount

I’m using this library in a react-router application and I have issues when using several detectors in different routes. On the first route, resize events are sent but when I go on a new route, then the library don’t send the dimensions anymore.

After a bit of investigations, I found that the element-resize-detector needs to be uninstall on componentWillUnmount since it is instantiated on each componentDidMount. (See https://github.com/wnr/element-resize-detector#uninstallelement).

This block should be replaced by:

 componentWillUnmount() {
    this.elementResizeDetector.uninstall(this.parentNode)
}

Then, everything works properly in React Router…

Do you want me to submit a Pull Request for this?

[okonet]

I would write a test that should check if the this.elementResizeDetector is properly uninitialized. Check out the existing tests and try it out. If you have question, please don’t hesitate to reach out to me and I’ll try to help!

[ValentinH]

Indeed, you are right, this is exactly how I modified the test to understand the issue 😃