Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move `prop-types` to regular `dependencies`

See original GitHub issue

prop-types  have been moved out of react for the very reason that it’s not mandatory in a React project …

If this module depends on it, it should be a regular dependency and not a peerDependency.

Issue Analytics

State:
Created 3 years ago
Comments:10 (7 by maintainers)

Top GitHub Comments

1reaction

vadzimcommented, Jun 1, 2020

I’ll be happy both with your last idea and with status quo.

0reactions

JalilArfaouicommented, Jul 6, 2020

Here you go !

https://github.com/okonet/react-scroll-sync/pull/39

Top Results From Across the Web

'prop-types' should be listed in the project's dependencies, not ...

'prop-types' should be listed in the project's dependencies, not devDependencies · Go to your package. · Save to the regular dependencies, not the ......

Remove prop-types from peer dependencies #87 - GitHub

My project doesn't use prop-types, is there a reason why it's a peer dependency?

How to validate React props using PropTypes - LogRocket Blog

Learn how to validate props with React PropTypes, React's internal mechanism for adding type checking to component props.

Why is prop-types not a dev dependency? : r/reactjs - Reddit

It's a dependency because it's needed at runtime. It's not merely part of the build process. It's true that if you use something...

prop-types | Yarn - Package Manager

Runtime type checking for React props and similar objects. You can use prop-types to document the intended types of properties passed to components....