Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

addRow function is not working properly on version 3.5

See original GitHub issue

When I want to add row to the top of the table, like this: $(selector).tabulator("addRow", {_id: 0}, true); I get this error: “ReferenceError: activeRows is not defined[Learn More] tabulator.min.js:2:29240”

This code was working on version 3.4.*

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

answerquestcommented, May 8, 2018

Yay, fixed it! Added activeRows declaration at the start of the function:

    RowManager.prototype.addRowActual = function (data, pos, index, blockRedraw) {

      var row = new Row(data || {}, this),
          top = this.findAddRowPos(pos),
          dispRows,
          activeRows = this.activeRows; // <-- define activeRows, copying from other places in the code

      if (!index && this.table.options.pagination && this.table.options.paginationAddRow == "page") {

        dispRows = this.getDisplayRows();

        if (top) {

          if (dispRows.length) {

            index = dispRows[0];
          } else {

            if (activeRows.length) { // <-- where the error was happening because activeRows wasn't defined

@olifolkerd I’m not going to do a PR as you’ll need to compile in gulp and all. Will learn that stuff some day so I can contribute.

@blackgod000 as a temporary fix, change your js src to tabulator.js, open it in a text editor, and add a line var activeRows = this.activeRows; at line number 2772, that should make things work for you.

0reactions

olifolkerdcommented, May 19, 2018

Hey @blackgod000

I have pushed a fix for this to the master branch and will include it in this evenings patch release.

Cheers

Oli 😃