question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

v1.3.0 introduced some breaking changes regarding attribute usage

See original GitHub issue

Prior to v1.3.0 you could use any atributes in the <img> tag declaration and these would be preserved during the <svg> transformation. 😢

Now all attributes are being removed in favor of the new addAttributes option. This is a problem if you’ve had different attributes values and properties per icon.

There is also another breaking change that class values are being transformed to lowercase, and since CSS is case-sensitive this break any icon that use a style name such as class="fooBar".

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
oliverfindlcommented, Oct 18, 2019

Hello,

issue with lowercase-ing attribute values should be fixed now.

Please give me feedback if it works as expected

Thanks

0reactions
oliverfindlcommented, Nov 11, 2019

Closing this issue.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Breaking changes in .NET Core 3.0 - Microsoft Learn
If you're migrating to version 3.0 of .NET Core, ASP.NET Core, or EF Core, the breaking changes listed in this article may affect...
Read more >
Morningstar Design System v1.3.0 - Versioning & Breaking Changes
A markup change that requires MDS users to update markup to align with breaking style change(s). Removing an html attribute or property (like...
Read more >
Release Notes — PynamoDB 6.0a0 documentation
BinaryAttribute and BinarySetAttribute have undergone breaking changes: The attributes' internal encoding has changed. To prevent this change going unnoticed, ...
Read more >
clap/CHANGELOG.md at master · clap-rs/clap - GitHub
The format is based on Keep a Changelog and this project adheres to Semantic Versioning. 5.0.0 - 2022-11-24. Breaking Changes. Made ArgPredicate ...
Read more >
Optional object type attributes with defaults in v1.3 alpha ...
To mark an attribute as optional, use the additional optional(. ... of this feature may see breaking changes even in minor releases.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found