PropTypes aren't removed when extending via Object.assign()

When a component extends from parent and the properties are extended, they are not removed.

Sample Code:

export default class ComponentB extends ComponentA {
    static propTypes = Object.assign({}, {
        stringKey: PropTypes.string.isRequired,
    }, ComponentA.propTypes)
}

[virgofx]

Here is an example use case. Think of complex logic that is required for rendering common components.

import React, { PureComponent } from 'react';
import PropTypes from 'prop-types';

class ComplexLogicComponent extends PureComponent {
    static propTypes = {
        baseKey: PropTypes.string.isRequired,
    }

     // Complex logic functions that depend on state
    doComplex() {} 
    getComplex() {}
    updateComplexData() {}

    // No render() since it's designed to be extended
}

/**
 * Component that requires complex logic
 */
class ComponentUsingComplex extends ComplexLogicComponent {
    static propTypes = Object.assign({}, {
        extraRenderProp: PropTypes.string.isRequired,
    }, ComplexLogicComponent.propTypes)

    render() { 
        // Use complex processing from parent to help render node
    }
}

I’ll submit a PR which addresses this hopefully by this weekend … should just be a quick fix in the isReactClass() to use a while loop instead of returning false.

Thanks for being open @oliviertassinari

[oliviertassinari]

I have tried out your example, that’s working as expected on my end. Here is the output:

import React, { PureComponent } from 'react';
import PropTypes from 'prop-types';

class ComplexLogicComponent extends PureComponent {

    // Complex logic functions that depend on state
    doComplex() {}
    getComplex() {}
    updateComplexData() {}

    // No render() since it's designed to be extended
}

/**
 * Component that requires complex logic
 */
class ComponentUsingComplex extends ComplexLogicComponent {

    render() {
        // Use complex processing from parent to help render node
    }
}

Still feel free to submit a PR if you find anything not working as expected.