Problem when notify_multiple_devices exceeds FCM_MAX_RECIPIENTS

@olucurious Thank you for providing such a solid solution for FCM. It is very cool!

I do find myself in a bit of a pickle when I use FCMNotification.notify_multiple_devices() and registration_ids length exceeds FCM_MAX_RECIPIENTS. Please see the pseudo code below which illustrates the problem.

registration_ids = [...] # 2000 entries
data_message = {...}
response_list = push_service.notify_multiple_devices(
    registration_ids=registration_ids, # gets chunked
    data_message=data_message
)
for response in response_list:
    for index, result in enumerate(response['results']):
        # index lies within the index range of this chunk of registration ids 
        # and will only ever be between 0-999.
        # Hence I've lost this association between this result and registration_ids

In order to mitigate this problem I have to employ the following workaround:

registration_ids = [...] # 2000 entries
data_message = {...}
registration_id_chunks = push_service.registration_id_chunks(registration_ids)
for chunk in registration_id_chunks:
    response = push_service.notify_multiple_devices(
        registration_ids=chunk,
        data_message=data_message
     )[0]
    for index, result in enumerate(response['results']):
        # now index refers to the correct registration_id within chunk

It would be nice if notify_multiple_devices() didn’t return a list of responses, but a single response. This response should be a concatenation of the chunked responses. I believe this would be a simple enough change within parse_responses

Greetings Moritz

[rmaciejczyk]

I think a simple solution is always the best. So what about creating a new function like notify_multiple_devices2 (or whatever name you’d like) with the new issue handling? and then you can even mark the previous function to be deprecated. I guess this is a typical way, isn’t it?

[olucurious]

@Proper-Job the issue has been resolved in the new release