Can no longer target a directory containing subdirectories with csproj files

In this commit on line 181, the ability to open a directory in which many subdirectories contained csproj files was removed.

https://github.com/OmniSharp/omnisharp-vscode/commit/369a904da6b7cbf4379f64bdc5496032548b4056#diff-c297262b72ad1ea22e80c49f21777b21eeab88e2c535f0286a387c392f85c91cL181

The logic was if ((hasCsProjFiles && !hasSlnFile) || (hasProjectJson && !hasProjectJsonAtRoot)) but now it is gone completely. This is exactly the condition in my project: no sln file anywhere, no project.json anywhere, and the root directory opened in vscode has a bunch of subdirectories, each of which contain csproj files.

What was the reason to remove the (hasCsProjFiles && !hasSlnFile) check to add a directory target?

I re-added the check in https://github.com/wuzzeb/omnisharp-vscode/commit/00894e1c3148eb70aa10b5679b6569caa0adc404 and it works perfectly for me.

Should I submit a pull-request? I am somewhat hesitant to submit a pull request because the check was deliberately deleted. Was there a reason to remove this development mode?

[JoeRobich]

Please try this prerelease https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.15-beta1

[lonix1]

Hi again @JoeRobich is this bug on the roadmap? It landed just a few days ago, that’s why I’m pushing - whereas a while from now it’ll just be another issue on the backlog.

So my question is, is this on the todo list for the next update / hotfix?

Hate to sound like a broken record but it’s a nasty one. Working on big projects is insanely difficult right now.