Debugger ignores module filter for modules with embedded symbols

Environment data

dotnet --info output: 5.0.200-preview.20601.7 VS Code version: 1.52.1 C# Extension version: ms-dotnettools.csharp-1.23.8 .omnisharp 1.37.6-beta.16

Steps to reproduce

1. settings.json:

{
    "csharp.unitTestDebuggingOptions": {
    "allowFastEvaluate": true,
    "enableStepFiltering": true,
    "logging": {
      "programOutput": true,
      "elapsedTiming": true,
      "engineLogging": false,
      "exceptions": true,
      "moduleLoad": false,
      "threadExit": false,
      "browserStdOut": false,
      "processExit": true
    },
    "requireExactSource": true,
    "suppressJITOptimizations": true,
    "justMyCode": true,
    "symbolOptions": {
      "searchPaths": [],
      "searchMicrosoftSymbolServer": false,
      "searchNuGetOrgSymbolServer": false,
      "moduleFilter": {
        "mode": "loadOnlyIncluded",
        "includeSymbolsNextToModules": false,
        "includedModules": [
          "MyUnitTests.dll",
        ]
      }
    }
  }
}

1. Enable All exceptions
2. Debug a test.
3. Debugger breaks on non-user code.

Expected behavior

Breakpoint settings should use symbolOptions or justMyCode setting. Or maybe we can have a different checkboxes for this.

Actual behavior

Symbols of xunit.runner.visualstudio.dotnetcore.testadapter.dll and xunit.runner.utility.netcoreapp10.dll are loaded and we see a breakpoint on exception inside the xunit code. I can’t disable All Exceptions because if an exception is thrown in a test, we don’t interrupt it with the User-Unhandled Exceptions setting.

[gregg-miskelly]

I should add: I generally recommend to NOT enable it. There are a few scenarios where it makes sense, but especially if you have JMC on, it can result in confusing behavior (and this bug is a perfect example of that) and/or poor performance.

[gregg-miskelly]

That option defaults to off in both Visual Studio and VS Code.