Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[bug] Country flag not showing in comments

See original GitHub issue

Describe the bug The country flag of a user is not showing in the comments. (example bottom of page)

Expected behavior Flag should be shown like in this issue #1127 afbeelding

Screenshots Possible problem mentioned by @tudi2d on Slack Could this be the reason? (Image from the user page) For the addComment in the store it is only creatorCountry: user.country ? user.country.toLowerCase() : null saved to the backend.

afbeelding

Issue Analytics

State:
Created 2 years ago
Comments:6 (1 by maintainers)

Top GitHub Comments

1reaction

danitrodcommented, Oct 25, 2021

My bad @thisislawatts! Forgot that we had releases for a moment. For some reason the flags were already showing before this update in the dev environment, just in prod one not. I believe this is because of legacy users and how the location was stored differently. This PR should fix and now display flags for both legacy/new accounts. Let’s see it the next release. But I definitely agree that an automated test would be the best way to go

1reaction

danitrodcommented, Sep 18, 2021

Should be a quick one, I’ll send a PR