question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

fclVersion field does not differentiate between languages/libraries

See original GitHub issue

Problem

The fclVersion field passed to providers does not specify which FCL library is sending the request (e.g. fcl-js or fcl-swift). This has the potential to cause confusion for consuming services.

Related: does it make sense to eventually define a global FCL version (i.e. a protocol version) that is shared across all language implementations?

Acceptance Criteria

The service should be able to determine both the library and version from the version field.

Context

This came up in a feature request to add the version field to fcl-swift: https://github.com/Outblock/fcl-swift/issues/4

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
chaseflemingcommented, Feb 15, 2022

appMetadata doesn’t exist yet. Just a proposed name. client works though too. I do think the option of keeping them separate as configurable vs not-configurable. And the point about thinking a value may be overridable if not separated is a good one. Do we think leaving the fclVersion at the root for now is fine then? Can drop it in 1.0.0 maybe.

And looks like @psiemens and @orodio both like the github url which is more unique of an identifier than a string so works for me too then.

0reactions
orodiocommented, Feb 15, 2022

oh i thought appMetadata already exists, client is more than fine thin fine then

Read more comments on GitHub >

github_iconTop Results From Across the Web

BerkeleyAutomation/python-fcl: Python binding of FCL library
First, install octomap, which is necessary to use OcTree. For Ubuntu, use sudo apt-get install liboctomap-dev . Second, install FCL using the instructions ......
Read more >
is framework class library(FCL) implemented separately for C# ...
No, there is just one implementation. A strong design goal in .NET was to make the framework implementation available to many languages.
Read more >
The Design and Implementation of FCL
FCL is an extension of the Tcl language that provides persistence for simple values, transactions, and a rudimentary object system.
Read more >
Standard Libraries (CLI) - Wikipedia
Not to be confused with LibXML. The Standard Libraries is a set of libraries included in the Common Language Infrastructure ... The Framework...
Read more >
FCL-STL, a Generics-Based Template Library for FreePascal
This library, once available, will mitigate the difference between the powers of these two languages. Key words: FreePascal, templates, generic programming, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found