Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Extend ScatterElements op with min and max reduction

See original GitHub issue

Following https://github.com/onnx/onnx/pull/3484, the ScatterElements operation supports add and mul reduction operations. Additionally supporting min, max, and mean operations would allow for the remaining unsupported torch_scatter ops to be supported by ONNX.

I think this would allow PyG models to be exported to ONNX. Currently the PyG softmax implementation uses scatter_max and scatter_sum. I’m hoping that these changes would be fairly easy to implement since the other reduction operations are already supported.

Tagging @shubhambhokare1 who contributed https://github.com/onnx/onnx/pull/3484 for guidance.

Issue Analytics

State:
Created a year ago
Comments:6 (1 by maintainers)

Top GitHub Comments

5reactions

philasscommented, Jul 21, 2022

I have started a PR for it locally here, https://github.com/philass/onnx/pull/1

I will submit it to ONNX when it is more polished

1reaction

ramkrishna2910commented, Jul 21, 2022

@philass and I are looking in to this right now

Top Results From Across the Web

ScatterElements - 16 vs 18 — ONNX 1.12.0 documentation

ScatterElements takes three inputs data, updates, and indices of the same ... (Opset 18 change): Adds max/min to the set of allowed reduction...

OpenMP min reduction and std::min - c++ - Stack Overflow

What the reduction clause implies is that each thread will have its own private copy initialized to the neutral element of the min...

Python Runtime for ONNX operators

Dn) before a BatchNormalization Op. This operator has optional inputs/outputs. ... The interval is specified by the inputs 'min' and 'max'.

Changelog - GitHub

The ONNX parser will automatically route ROIAlign ops through the plugin. ... factors to optimize softmax MAX reduction in versions 2 and 3...

Function-Level Support Status - Neural Network Libraries

Reduction. Arithmetic. Logical ... Expand. ✓. ✓. Reshape, Broadcast. EyeLike. X. Not yet implemented. Flatten ... Max, Neg, Constant, Min. LogSigmoid.