question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow filtering HTTP auto instrumentation request errors

See original GitHub issue

Feature Request

Is your feature request related to a problem?

We’re using HTTP auto instrumentation in our applications and we would like to be able to change some “false” errors in order to get a better visualization on the UI, for example: A request to AWS/S3 to get a file which returns a 404, most of the time this is used by us to check if the file exists (it’s not an error per se, in this context).

I think this subject is controversial, but I would like to know the contributors opinion on that. My company has just started to instrument applications with distributed tracing so it would be nice to know if others had problems like this as well in their instrumentation, opinions on the matter and any workarounds.

Describe the solution you’d like:

Maybe the HTTP auto instrumentation initialization could have a parameter just like the Filter one, which will be called to decide whether a finished HTTP activity should be tagged with Status.Ok or Status.Error.

Which alternative solutions or features have you considered?

We tried to .SetStatus(Status.Ok) using the Enrich feature - It didn’t work though. As a workaround we enriched the activity with an error=false attribute (on our specific tracing backend this worked, but it seems to be a unreliable workaround).

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
cijothomascommented, Nov 13, 2020

Fix for AspNet: https://github.com/open-telemetry/opentelemetry-dotnet/pull/1537 HttpClient is coming next.

0reactions
eddynakacommented, Nov 16, 2020

@cijothomas , just created a PR solving the remaining ones

Read more comments on GitHub >

github_iconTop Results From Across the Web

NET Framework instrumentation configuration
ASP.NET instrumentation collects all incoming HTTP requests by default. However, you can filter incoming requests by using the Filter method in ...
Read more >
Filtering and preprocessing in the Application Insights SDK
This technique gives you direct control over what's included or excluded from the telemetry stream. Filtering can be used to drop telemetry ...
Read more >
AWS X-Ray auto-instrumentation agent for Java
The AWS X-Ray auto-instrumentation agent for Java is a tracing solution that instruments your Java web applications with minimal development effort.
Read more >
Correlate Request Logs With Traces Automatically
Datadog automatically links your distributed request traces to logs from the same transaction for end-to-end visibility.
Read more >
Micronaut Tracing
The Micronaut Tracing Brave HTTP brings HTTP filters for auto instrumentation of your requests. If you don't need HTTP filters you can only...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found