question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Review namespace and organization of Baggage APIs

See original GitHub issue

The specification suggests Baggage as a top-level API https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/library-layout.md#api-package.

Currently Baggage is in the OpenTelemetry namespace https://github.com/open-telemetry/opentelemetry-dotnet/blob/fe2476852131c3bc3a4b5b190cd5970cf46059a9/src/OpenTelemetry.Api/Baggage.cs#L22-L31

and the BaggagePropagator is in the OpenTelemetry.Context.Propagation namespace https://github.com/open-telemetry/opentelemetry-dotnet/blob/fe2476852131c3bc3a4b5b190cd5970cf46059a9/src/OpenTelemetry.Api/Context/Propagation/BaggagePropagator.cs#L24-L30

The spec seems to suggest something more like:

namespace OpenTelemetry.Baggage
 { 
     public readonly struct Baggage : IEquatable<Baggage> 
     {

and

namespace OpenTelemetry.Baggage.Propagation
 { 
     public class BaggagePropagator : TextMapPropagator 
     { 

OpenTelemetry.Baggage.Baggage kinda feels ewwwww… 🥴

I’m not familiar enough with baggage to know what kind of thought went into the organization we have. Hoping for other’s input. @CodeBlanch @reyang @cijothomas

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
cijothomascommented, Feb 5, 2021

@cijothomas what’s your gut say about moving Baggage to the OpenTelemetry.Context namespace? Would this just complicate things at this point?

Agree its slightly more correct to have Baggage under Context. But the benefit is small compared to making a last minute change.

0reactions
cijothomascommented, Feb 5, 2021

Closing this as we have reached 1.0 and no breaking changes can be made.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Namespaces API | GitLab
Namespaces API. Usernames and group names fall under a special category called namespaces. You might also want to view documentation for:.
Read more >
API concepts :: Gloo Mesh Enterprise Docs
Learn about the core concepts behind Gloo Mesh, including Kubernetes, Envoy, and Istio. Diagram of APIs by persona persona. Using the API. Review...
Read more >
What happens to my namespace prefix when I install a ...
A namespace prefix is a globally unique identifier that you can request if you plan to create a managed package. All the components...
Read more >
Tooling API from Visualforce - OK in managed package?
That's going to be OK as long as the namespace of the packages you are creating is different from the namespace of your...
Read more >
Kubernetes API Concepts
Namespace -scoped resources: GET /apis/GROUP/VERSION/RESOURCETYPE - return the collection of all instances of the resource type across all  ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found