[BUG] 5.0.0 breaks generator if servers url relative
See original GitHub issueHi recently switch from openapi-generator-maven-plugin@4.3.1 to 5.0.0 and the generation of my swagger did not work anymore.
After hours of search, I finaly found that it was mu servers > url value that breaked the generation. Of course my swagger is valid according to https://apitools.dev/swagger-parser/online/ (and many others). And also specification : https://swagger.io/specification/#server-object
Field Name | Type | Description |
---|---|---|
url | string | REQUIRED. A URL to the target host. This URL supports Server Variables and MAY be relative |
Step to reproduce :
Take the classic petstore : https://raw.githubusercontent.com/OAI/OpenAPI-Specification/master/examples/v3.0/petstore.yaml Change
servers:
- url: http://petstore.swagger.io/v1
To
servers:
- url: /v1
Run
java -jar openapi-generator-cli.jar generate -i <path_to/petstore.yaml> -g spring
Breaks with error (unclear at all)
com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'openapi': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
I guess it breaks all generator cause it also break validate command.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:9
- Comments:16 (6 by maintainers)
Top GitHub Comments
I think this is the underlying cause: https://github.com/swagger-api/swagger-parser/issues/1553
What is the usual timeframe for making a new release of
openapi-generator
in maven repositories which includes the fix shipped in https://github.com/swagger-api/swagger-parser/issues/1553? Is this considered critical enough to warant a quick release for the team? (cc @wing328 as I see the user in the Github releases page)As currently this breaks builds for our Windows developers without involving and running the maven target for openapi-generator under WSL2 in Windows after we upgraded from 4.3.1 to 5.1.0.
Thanks @jhannes for finding the underlaying cause and fixing this upstream.