question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG][typescript-axios] Using allOf with a $ref and an object, along with `withSeparateModelsAndApi` generates broken imports

See original GitHub issue

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What’s the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

Using allOf with a $ref and an object, along with withSeparateModelsAndApi generates broken imports

openapi-generator version

5.1.0

OpenAPI declaration file content or url
openapi: 3.0.2
info:
  title: hello
  version: 1.0.0
components:
  schemas:
    SomeSchema:
      type: object
      properties:
        some_prop:
          type: integer
paths:
  /foobar:
    get:
      responses:
        200:
          description: ok
          content:
            application/json:
              schema:
                allOf:
                  - $ref: '#/components/schemas/SomeSchema'
                  - type: object
                    properties:
                      foobar: 
                        type: string
Generation Details
openapi-generator-cli generate -i http://localhost:8000/swagger.yml -g typescript-axios -o foo -p "withSeparateModelsAndApi=true,modelPackage=models,apiPackage=api"
Steps to reproduce
  1. Run the above command with the provided yaml file
  2. Look at the generated default-api.ts

On line 24, it creates an invalid import statement: import { SomeSchema & object } from '../models';

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:1
  • Comments:9 (3 by maintainers)

github_iconTop GitHub Comments

3reactions
sarumontcommented, Mar 25, 2022

@funkeyfreak Not sure… #9031 seems unrelated. I’m a bit crunched for time right now, but I’ll try to get some tests into my PR soon to get it merged. 😃

0reactions
funkeyfreakcommented, Mar 23, 2022

@sarumont, do we expect this code change to resolve #9031? If so, I’ll give this a whirl on the typescript-angular generator.

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found