Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve unsaved changes modal

See original GitHub issue

There’s a few issues with the unsaved changes modal that we should clean up when we have a chance.

Simply providing Yes No buttons isn’t clear enough. We should provide more context in the button label, e.g. Yes, close or No, don't close.
The Yes, close button should be on the right side as it implies forward progress, while No, don't close takes you back.
I cleaned up the styling of the modal a bit (buttons are larger and headline text is smaller). It feels more balanced this way.

Current screenshot 2018-07-31 21 23 41

Ideal screenshot 2018-08-02 11 24 23

Issue Analytics

State:
Created 5 years ago
Comments:16 (16 by maintainers)

Top GitHub Comments

1reaction

morebrowniescommented, Aug 22, 2018

@jashot7 sorry for the delay. Tested this PR today and overall it’s looking really great. Only suggestion I have is to flip the buttons on the restart dialog. (Restart now should be on the right side)

screenshot 2018-08-22 11 11 47

The OpenBazaar Wallet Setup screen will be going away soon so I’m fine with the HR changes there. Keeping onboarding as is works for me too.

👍

1reaction

morebrowniescommented, Aug 17, 2018

Ok thanks @jashot7 I’ll catch up on this when I can. Hang tight

Top Results From Across the Web

What is a good approach for warning user on leaving a modal ...

I would recommend having a pop-up modal asking the user that there is unsaved information that he will lose. It's weird to click...

Communicating unsaved changes - Cloudscape Design System

A confirmation modal prevents data loss when unsaved changes exist on the page. However, it's not necessary if a user hasn't made any...

How to prevent cancel modal if there is unsaved changes in ...

My Angular app creates a modal dialog to allow user to input and change some properties. It is requested to warn user that...

Modal Dialog Form: UX improvements relating to closing of ...

If/when a user fills in data in a Modal Form, and accidentally click outside the Modal, the form will be closed and any...

Unsaved changes modal UX pattern · FOLIO UX docs

Unsaved changes modal UX pattern. This modal is a confirmation modal that prevents users from leaving a create/edit record page without saving changes....