Feign HeaderTemplates adds an extra space to date headers after commas

HeaderTemplates#expand(Map<String, ?>) adds space after each comma in headers. This causes an issue when converting date that uses the EEE, d MMM yyyy HH:mm:ss Z format.

Example Client code sends Wed, 4 Jul 2001 12:08:56 -0700 Provider expects Wed, 4 Jul 2001 12:08:56 -0700 Provider receives Wed, 4 Jul 2001 12:08:56 -0700 please note the extra space between the , and 4

[jjz921024]

hi, i made pr #1295 for fix this issue, but CI build failed because of The command "./travis/no-git-changes.sh" exited with 1 i don’t know how to make it build successfully

Looks like it’s complaining about code formatting; did you see this in the build output?

Please run 'mvn clean install' locally to format files.

At a guess I’d say it’s because you have two blank lines above your new unit test method, and the formatter expects only one. But I guess mvn clean install will fix this for you.

Thank for you reply. you are right, it is caused by formatting, but it’s because there are blank lines in import statement, not unit test method

[superfive666]

@deniskichan You just need to manipulate the headers you sent in each individual requests. But have you tried upgrade to the newest version first?