GET method with @RequestLine @Param containing a question mark (/index.php?/) is converted to POST

Hi. I came from https://github.com/OpenFeign/feign/issues/838 This has been fixed in https://github.com/OpenFeign/feign/pull/841

When i use the code from last comment:

@RequestLine(value = "GET /index.php?/api/v2/get_tests/{runId}")
    @Headers({
            "Content-Type: application/json",
            "Accept: */*",
    })
    Test[] getTestsByRunId(@Param(value = "runId") Integer runId);

i get the following error even though i use the GET method (hide server & Authorization string):

 [feign.Logger] ---> GET https://testrail.server.domen/testrail/index.php?/api/v2/get_tests/999 HTTP/1.1
[feign.Logger] Accept: */*
[feign.Logger] Authorization: Basic *hidden*
[feign.Logger] Content-Length: 13
[feign.Logger] Content-Type: application/json
[feign.Logger] 
[feign.Logger] {"runId":999}
[feign.Logger] ---> END HTTP (13-byte body)
[feign.Logger] <--- HTTP/1.1 404 File Not Found (974ms)
[feign.Logger] connection: keep-alive
[feign.Logger] content-length: 61
[feign.Logger] content-type: application/json; charset=utf-8
[feign.Logger] date: Thu, 03 Oct 2019 08:58:19 GMT
[feign.Logger] server: nginx/1.10.2
[feign.Logger] x-powered-by: PHP/5.4.45
[feign.Logger] 
[feign.Logger] {"error":"Unsupported HTTP method \"post\" for this action."}
[feign.Logger] <--- END HTTP (61-byte body)
```

[kdavisk6]

I found the issue. The code we have was only evaluating template variables on a query string when they are present in the query parameter value part of the expression. We were not accounting for expressions that occur in the query parameter name portion, which is how query expressions presented in this issue get processed. This is due to the fact that we expect name=value pairs on a query string when parsing.

I will work on a fix and present a PR shortly.

[iNTEAM]

@kdavisk6 i use this example but get an error:

Content-Type header invalid (use Content-Type: application\/json)

i try next scenarios but get same error:

1. Use POST
2. update versions of all feign libraries

Here is my API:

public interface CasesControllerApi {
    @RequestLine(value = "GET /index.php?/api/v2/get_tests/{runId}")
    @Headers({"Content-Type: application/x-www-form-urlencoded"})
    Test[] getTestsByRunId(@Param(value = "runId") Integer runId);
}

my feignBuilder:

        feignBuilder = Feign.builder()
                .encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
                .decoder(new JacksonDecoder(objectMapper))
                .logger(new Slf4jLogger());

Log:

---> GET https://myurl.com/testrail/index.php?/api/v2/get_tests/999 HTTP/1.1
Content-Length: 9
Content-Type: application/x-www-form-urlencoded; charset=UTF-8

runId=999
---> END HTTP (9-byte body)
<--- HTTP/1.1 400 Bad Request (771ms)
connection: keep-alive
content-length: 77
content-type: application/json; charset=utf-8
server: nginx/1.10.2
x-powered-by: PHP/5.4.45

{"error":"Content-Type header invalid (use Content-Type: application\/json)"}
<--- END HTTP (77-byte body)