[fmiweather] Cannot add discovered things from inbox in OH3 / cannot create things manually
See original GitHub issueOK## Expected Behavior
- Adding FMI weather things from inbox works without errors
- creating things manually would be possible
Current Behavior
When trying to add discovered FMI weather thing, it fails with an error in the logs:
23:56:11.518 [INFO ] [ig.discovery.internal.PersistentInbox] - Added new thing 'fmiweather:observation:station_100996_Helsinki_Harmaja' to inbox.
23:56:11.518 [INFO ] [smarthome.event.InboxAddedEvent ] - Discovery Result with UID 'fmiweather:observation:station_100997_Kirkkonummi_Makiluoto' has been added.
23:56:11.518 [INFO ] [ig.discovery.internal.PersistentInbox] - Added new thing 'fmiweather:observation:station_100997_Kirkkonummi_Makiluoto' to inbox.
23:56:32.782 [ERROR] [enhab.core.thing.binding.ThingFactory] - Thing factory (class org.openhab.binding.fmiweather.internal.HandlerFactory) returned null on create thing when it reports to support the thing type (fmiweather:forecast).
23:56:32.782 [WARN ] [ig.discovery.internal.PersistentInbox] - Cannot create thing. No binding found that supports creating a thing of type fmiweather:forecast.
In addition, it is not possible to create the things using MainUI
Steps to Reproduce (for Bugs)
- Settings -> Things -> Inbox -> select any FMI weather thing -> Add as thing. OK to accept suggested thing name
- Error appears
Context
FMI weather unusable in openHAB3
Tried with fresh manual install of openHAB 2.5.10, work flawlessly there so it appears to be regression in OH3.
Your Environment
- Version used: (e.g., openHAB and add-on versions)
- Environment name and version (e.g. Chrome 76, Java 8, Node.js 12.9, …):
- Operating System and version (desktop or mobile, Windows 10, Raspbian Buster, …):
Fedora linux
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment 18.9 (build 11.0.9+11)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.9+11, mixed mode, sharing)
openHAB 3.0 M2, manual runtime installation, with openhab-addons-3.0.0.M2.kar
in addons
. Only FMI weather binding installed
Issue Analytics
- State:
- Created 3 years ago
- Comments:8 (8 by maintainers)
Top Results From Across the Web
openHAB 3.0 Milestone 2 discussion
[fmiweather] Cannot add discovered things from inbox in OH3 / cannot create things manually · Introduce "expire" functionality for item states.
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
We found the reason. See https://github.com/openhab/openhab-core/commit/aae207bfe95da3b0b7eaaf08e4beda546a1c228d#r43959474
Thanks to @J-N-K for fixing it.
@ssalonen Sry, I currently have no idea. But it might be related because the fix commited by @J-N-K prevents this exception during XML parsing: