question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Colors in light theme too bright

See original GitHub issue

When using valuecolor=[ON="green"], basic UI shows a darker green than the app. Even when chaning the basic-ui theme, an intensiv light green (seems `#00FF00’) is shown.

This is too bright for a white background.

We should change the colors at least in the basic-ui theme to match the basic ui and provide better accessibility through higher contrast.

Here’s a quick comparison between basic UI (first) and app (second) 2018-01-13 08_36_35-technik

img_20180113_084202

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:17 (17 by maintainers)

github_iconTop GitHub Comments

1reaction
maniac103commented, Mar 8, 2018

@mueller-ma Working diff to your current state: https://pastebin.com/8atxWmMZ … however, I would strongly suggest to

  • make OpenHABWidget store the string representation only, not the parsed color and
  • move parsing to the view adapter (optimization: resolve the arrays only once, maybe by adding an additional setter to ViewHolder called from onCreateViewHolder)

Benefit of that is that OpenHABWidget and friends stay dumb data holders without any theme dependency; after all they’re not reloaded on theme changes.

1reaction
maniac103commented, Jan 17, 2018

One pointer for resource arrays: http://www.davidebasso.me/android/android-color-list-arrays-in-xml/ … just needs the attribute-to-resource-ID added on top.

In particular, we’d need one such array per them defined in arrays.xml and then need a theme attribute that references the respective array.

Read more comments on GitHub >

github_iconTop Results From Across the Web

I'd use light theme if it wasn't so bad. : r/discordapp - Reddit
Light theme is obnoxiously bright to the point of unusability - I like light themes on PC but this one is unbearable.
Read more >
[Windows 10] Color are too bright on my screen
Press Windows + I key to open Windows Settings. · Click on Ease of Access and select Color Filters from the left pane....
Read more >
Why You Should Avoid Bright, Saturated Background Colors
Bright, saturated colors attract the most user attention. Too much of it in a large area overstimulates the retinas which can strain the ......
Read more >
With solarized colors: Time invisible for light theme, too bright ...
When using the popular solarized color themes, The time is nearly invisible in the light variant, too bright in the dark.
Read more >
Dark or white color theme is better for the eyes?
Part of this has to do with light levels: with a bright display (white background) the iris closes a bit more, decreasing the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found