Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Type definition for Attribution is not consistent with the documentation

See original GitHub issue

Describe the bug The documentation clearly states that the label can either be a string or an element (like span). However, the Type Definition for Options.label = string. I think it should be types the same as Options.collapseLabel.

To Reproduce See ol/attribution/Attribution.js

Expected behavior The solution is quite easy:

...
* @property {string|HTMLElement} [label='i'] Text label to use for the
* collapsed attributions button.
...

Issue Analytics

State:
Created 2 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

mike-000commented, Oct 11, 2021

css class names are strings. The Instead of text, also an element (e.g. a span element) can be used. line should not be there and appears to have been separated from the labelActive description by the insertion of the class name options.

1reaction

tschaubcommented, Oct 8, 2021

Thanks for the report, @MatthijsBon. A pull request to fix this would be great.

Top Results From Across the Web

Fundamental Attribution Error - Simply Psychology

The fundamental attribution error (also known as correspondence bias or over-attribution effect) is the tendency for people to over-emphasize dispositional, or ...

Understand attribution reporting - Knowledge Base - HubSpot

Learn the definitions for asset types, content types, interactions types and sources and more in the attribution report builder.

Citation vs. Attribution – Self-Publishing Guide

An attribution statement is used to provide credit to the original creator; its purpose is similar to a citation. Best practice says that...

Fundamental Attribution Error: What It Is & How to Avoid It

The fundamental attribution error plays a central role in how we understand the actions of others and how we justify our own.

Best practices for attribution - Creative Commons Wiki

Because each use case is different, you can decide what form of attribution is most suitable for your specific situation.