No way for update arguments via IMAGES_HOOK anymore

Description Since 5.6 we have nice locking mechanism. But all new images created with LOCKING enabled. So if you have some hook which adds some custom parameters to creating images, it will not work anymore.

IMAGE_HOOK supports only CREATE and DELETE operations, no way to call it after image is READY

To Reproduce

• Write hook for adding specific label to the image:

#!/bin/sh
EDITOR="echo LABELS=mylabel >" oneimage update --append $1

• Install hook in oned.conf:

IMAGE_HOOK = [
    name      = "add_label",
    on        = "CREATE",
    command   = "add_label.sh",
    arguments = "$ID" ]

• Upload new image, alpine for example:

http://dl-cdn.alpinelinux.org/alpine/v3.8/releases/x86_64/alpine-standard-3.8.1-x86_64.iso

• In logs you will see error

[Z0][ImM][I]: Copying http://dl-cdn.alpinelinux.org/alpine/v3.8/releases/x86_64/alpine-standard-3.8.1-x86_64.iso to repository for image 1440
[Z0][ReM][E]: Req:6704 UID:0 one.image.update result FAILURE [one.image.update] User [0] : IMAGE is locked. [1440].

Expected behavior Attached label to the image

Details

• Affected Component: Core
• Hypervisor: KVM
• Version: 5.6.0

Progress Status

• Branch created
• Code committed to development branch
• Testing - QA
• Documentation
• Release notes - resolved issues, compatibility, known issues
• Code committed to upstream release/hotfix branches
• Documentation committed to upstream release/hotfix branches

[kvaps]

For now I use:

oneimage unlock "$1"

as workaround, in my hook it is working fine

[atodorov-storpool]

Same problem when importing an image issue #2292