[BUG] Breaking changes with opensearch.http.override_main_response_version=true

There are a number of breaking changes in 2.0 RESTful APIs. I suspect (still need to confirm) that breaks opensearch.http.override_main_response_version=true (https://opensearch.org/docs/latest/clients/agents-and-ingestion-tools/index/).

I think we have two options.

a) Remove opensearch.http.override_main_response_version=true. b) Ensure backwards compatibility.

This is tangentially related to https://github.com/opensearch-project/opensearch-clients/issues/17.

[nknize]

That would be the upgrade path: upgrade client to 2.0, it should work for both versions, than start upgrading clusters.

That is the correct upgrade path for clients depending on the HLRC.

opensearch.http.override_main_response_version=true doesn’t impact the node connectivity with ES 7.10

Correct. opensearch.http.override_main_response_version=true does not impact internal node connectivity it was only added to ensure compatibility w/ legacy 7.x clients. I’m sorry if that wasn’t clear. My point is that 2.0.0 supports Transport API compatibility back to 7.10.0. The HLRC (client facing API) does not include Version.onOrAfter logic so it doesn’t subscribe to the same compatibility guarantees; it follows the same deprecation / removal path as features which is why the types endpoints were removed (after being deprecated in 7.x/1.x).

I’m not sure the project should be shy about 2.0.0 having breaking changes

💯

there is some dissonance between OpenSearch 2.0.0 saying it’s 7.10.2 yet not having the same API

Agree. I’ve slept since we removed the transport client December of last year so we don’t need to retain transport client compatibility (nor should the REST client spoofing matter here).

+1 for removing the override_main_response_version property and forcing client upgrades.

[nknize]

Can anyone pick this up?

opensearch-project/OpenSearch#3031