[BUG] Gradle check retry not working as expected
See original GitHub issueDescribe the bug
- As a part of https://github.com/opensearch-project/OpenSearch/issues/2547 and https://github.com/opensearch-project/OpenSearch/pull/2638/, a retry mechanism was introduced to rerun failed tests during
gradle check
- With the increased flakiness in tests, one issue that was noticed is the retries do not always run for tests on the build server
Sample runs -
- https://build.ci.opensearch.org/job/gradle-check/6825/consoleFull
- https://build.ci.opensearch.org/job/gradle-check/6782/
To Reproduce
- Run gradle check for a PR with a test failure
Expected behavior
- Retries to be present within the console output with
x tests completed, y failed
with y > 1 in case of failed tests with a retry
Plugins
- N/A
Screenshots
- https://build.ci.opensearch.org/job/gradle-check/6825/consoleFull
- https://build.ci.opensearch.org/job/gradle-check/6782/
Host/Environment (please complete the following information):
- Jenkins build server for OpenSearch
Additional context
Issue Analytics
- State:
- Created 10 months ago
- Comments:11 (11 by maintainers)
Top Results From Across the Web
Unable to retry test methods from parent classes with Spock 2
org.gradle.test-retry was unable to retry the following test methods, which is unexpected. Please file a bug report at ...
Read more >Jenkinsfile clear gradle cache and retry on failure
Current scenario: We have configured CI pipeline and running a jenkinsfile.groovy script for a gradle build. The pipeline is working fine ...
Read more >Learning the Basics - Gradle User Manual
There are different issues with using mavenLocal() that you should be aware of: Maven uses it as a cache, not a repository, meaning...
Read more >Flaky test detection doesn't consider multiple runs of the same ...
Gradle build is successful. When "support test retry: successful test run mutes previous test failure" is unchecked, adding teamcity.internal.
Read more >Gradle Enterprise Predictive Test Selection User Manual
In order to obtain an accurate estimate of expected Predictive Test Selection quality, it is recommended to inspect incorrect predictions and omit simulations...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Again looking at 6825, we see the “BUILD SUCCESSFUL” result in the output (tests succeeded on retry):
The gradle check jenkins run completes with the result “UNSTABLE” and results in a failure of the GitHub action. Is this the right behavior? I think the point of the retries is to pass the gradle check when tests pass on retry so this seems wrong to me.
Fix: https://github.com/opensearch-project/opensearch-build/pull/2902