[Bug] Path comparison issues causing plugin not able to build on Windows
See original GitHub issueComing from https://github.com/opensearch-project/dashboards-reports/issues/191#issuecomment-1291166886.
The issue being that Windows treat Administrator
dir and ADMINI~1
dir as the same on Windows.
But the code here in dashboards core is using ===
to compare:
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/d7004dc5b0392477fdd54ac66b29d231975a173b/packages/osd-plugin-helpers/src/load_opensearch_dashboards_platform_plugin.ts#L47
const isRootPlugin = parentDir === Path.resolve(REPO_ROOT, 'plugins');
This cause a diff in comparison between these two paths in .ts, while on windows they point to the same location:
C:\Users\Administrator\AppData\Local\Temp\2\tmpndbrtuhg\OpenSearch-Dashboards\plugins
C:\Users\ADMINI~1\AppData\Local\Temp\2\tmpndbrtuhg\OpenSearch-Dashboards\plugins
This then cause the failure when building dashboards plugin:
+ yarn plugin_helpers build --opensearch-dashboards-version=2.4.0
yarn run v1.22.19
$ node ../../scripts/plugin_helpers build --opensearch-dashboards-version=2.4.0
ERROR Plugin located at [C:\Users\Administrator\AppData\Local\Temp\2\tmpzgwnkv7a\OpenSearch-Dashboards\plugins\dashboards-reports] must be moved to the plugins directory at the root of the OpenSearch Dashboards repo
error Command failed with exit code 1.
Thanks.
Issue Analytics
- State:
- Created a year ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Windows Admin Center known issues | Microsoft Learn
If you have Windows Admin Center installed as a gateway on Windows Server 2016 under heavy use, the service may crash with an...
Read more >Troubleshooting builds - Gradle User Manual
If gradle --version works, but all of your builds fail with the same error, it is possible there is a problem with one...
Read more >Common Bugs and Pitfalls - Apache Maven
URLs and filesystem paths are really two different things and converting between them is not trivial. The main source of problems is that...
Read more >Known issues with Android Studio and Android Gradle Plugin
This error occurs on Linux-based platforms when starting the native debugger. It indicates that one of the libraries required by the native debugger...
Read more >Bug listing with status RESOLVED with resolution FIXED as at ...
Bug :2 - "How do I attach an ebuild. ... in ebuilds when java/bin is not in root's path" status:RESOLVED resolution:FIXED severity:normal ·...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Rolled out with 2.4.0.
I would say the best solution is to find a way to resolve this on typescript side, without pushing windows agent to disable short names.
Since there will be community members using this code to build themselves.
Thanks.