Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug in commit 5686daa

See original GitHub issue

In commit 5686daa there is a bug

ERROR in ./src/MusicalScore/Graphical/VexFlow/SvgVexFlowBackend.ts
./src/MusicalScore/Graphical/VexFlow/SvgVexFlowBackend.ts 188:36-47
[tsl] ERROR in ./src/MusicalScore/Graphical/VexFlow/SvgVexFlowBackend.ts(188,37)
      TS2554: Expected 1-3 arguments, but got 0.

ctx.openGroup() cannot be called with 0 parameters.

Issue Analytics

State:
Created 2 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

rvilarlcommented, Jan 10, 2022

you are right, the error is in VexFlow, sorry for that. The first string is checked not to be undefined. I will fix that in VexFlow and you can undo this one if you want.

1reaction

sschmidTUcommented, Jan 7, 2022

@rvilarl I’m fixing this by updating the definitions in DefinitelyTyped (only relevant for Vexflow 1.2.93 or 3.0.9). The definitions for openGroup() were missing the parameters: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/29216607f433cbb900acdcf4a0e4ea69e9db5376/types/vexflow/index.d.ts#L74

I’ve submitted a PR to DefinitelyTyped: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/58042

It should be merged soon.