Chord symbols overlap with notes above stave.

I’d like to add my support for the idea of developing a collision detection and spacing method for chord symbols.

In the first example the chord symbols overlap with most notes above the stave. In the second example I set the Y offset higher with osmd.EngravingRules.ChordSymbolYOffset = 4.0;. This avoids most collisions but it sets the chord symbol position too high. Most scores in the app I’m building don’t have notes above the stave, so in those cases it will look a bit odd to have the chord symbols this high.

[sschmidTU]

Chord symbol overlap is now fixed, symbols are positioned above the skyline (highest colliding point):

You can also align the y positions of the chord symbols, either per measure or per staffline:

osmd.EngravingRules.ChordSymbolYAlignment = true;
osmd.EngravingRules.ChordSymbolYAlignmentScope = "staffline"; // or "measure"
// YOffset is mostly not needed anymore:
osmd.EngravingRules.ChordSymbolYOffset = 0.1;

Implementation is similar as in #1081, which made it much easier to implement now.

[sschmidTU]

It looks like staffline alignment scope should be the standard, as the measure wise alignment scope with its ups and dows of positioning looks a bit unattractive to me in the visual diffs of our samples:

measure wise alignment:

staffline wise alignment looks much better, and basically doesn’t use more space except maybe potentially for the composer label in some cases This sample has actually only 1 pixel more height with staffline alignment than with measure alignment. (997 vs 996)

Also, this general implementation saves space compared to before anyways, because we’re right above the skyline now, and don’t need a big default offset applied to every chord symbol. diff_chord_alignment_staffline_wise.zip diff_chord_alignment_measure_wise.zip

The staffline diffs are basically pure improvements in 7 samples. Feel free to share or test your own samples.