Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
StaveRepetitions wrong x positions (D.S., To Coda, etc)
See original GitHub issueAlready fixed.
Before:
After:
test_staverepetitions_coda_etc.musicxml.zip
MuseScore (3.5.2) doesn’t render this very well by the way:
The issue was a few NaNs in Vexflow from undefined measurements (x/y values), i added safeguards against those to our Vexflow patch.
Also, TO_CODA didn’t exist as a Vex.Flow.Repetition.type (in staverepetition.js), added that to the patch as well.
Also new EngravingRule RepetitionSymbolsYOffset.
Issue Analytics
- State:
- Created 3 years ago
- Comments:9 (6 by maintainers)
Top Results From Across the Web
D.S., D.S. al Coda
D.S., D.S. al Coda. D.S., or Dal Segno, means “from the sign.” It directs the player to return to a spot earlier in...
Read more >Clinic: Repeats - D.C & D.S al Coda - YouTube
Clinic #14Repeats. MusicTheoryGuy answers a question from Gilberto in Los Angeles, USA. This video is the fourth in a six-part series of ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
This should be finally fixed now:
These test samples are added to our tests, see
test/data/test_staverepetitions_coda_etc*.@djae88 As you suggested, ‘To Coda’ is now fixed to the end of the measure. There was actually another error where the To Coda was attributed to the wrong measure (1 instead of 2), see above commit 9643493.
Fixed all right-oriented repetitions (backwards jumps) to be near the end of the measure. before:
after:
before:
after:
before:
after:
before (Coda_Left):
after:
(Coda (left) was turned to TO_CODA because of checks in the RepetitionInstructionReader that tried to balance Coda and To Coda occurences)
samples (all repetition types): repetition_types_all_code_DaCapo_DalSegno_etc.zip
Running visual regression tests in #1265.