Wrong key signature(After setting drawFromMeasureNumber)

The treble clef is displayed at the beginning of the score, and then there is a treble clef at the end of the 8th bar. Normally, the 9th bar should be the treble clef, but when I cut from the 9th bar, the treble and bass clef is still displayed.

correct performance:

osmd.setOptions({
  drawFromMeasureNumber: 5,
  drawUpToMeasureNumber: 0
})

You can see that in the 9th bar here, the left and right hands are all treble clefs.

Note: There is a treble clef at the end of bar 8

wrong performance:

osmd.setOptions({
  drawFromMeasureNumber: 9,
  drawUpToMeasureNumber: 0
})

The left and right hand display in section 9 here is incorrect.

I think it may be that after setting drawFromMeasureNumber , the calculation of the clef did not consider the information of the previous section.

file: quanwu.xml.zip

[rianlu]

when the clef is in the middle of the bar, I can’t get this information. Is there a related API to get it?

@rianlu In that case, the clef (ClefInstruction/AbstractNotationInstruction) is not in FirstInstructionsStaffEntries, but in another staffentry -> staffentry.Instructions. So, you have to loop over sourceMeasure.VerticalSourceStaffEntryContainers and then over verticalSourceStaffEntryContainer.StaffEntries, which have Instructions, and check if one of these is a KeyInstruction.

Thanks for the answer, now I have solved the problem! On the basis of the previous, I added a new method: checkMiddleClefByMeasureIndex(measureIndex)

forMeasure:
for (let measureIndex = start - 2; measureIndex >= 0; measureIndex--) {
    ... ...
    for (let j = 0; j < lastInstructions.length; j++) {
        ... ...
    }
    // 检查小节中间的谱号
    checkMiddleClefByMeasureIndex(measureIndex)
    if (updateClefObj !== undefined && updateClefObj.leftClef !== undefined && updateClefObj.rightClef !== undefined) {
        break forMeasure
    }
}
  
// new method
/**
 * 检查小节中谱号信息
*/
function checkMiddleClefByMeasureIndex(measureIndex) {
    console.log(measureIndex)
    const sourceMeasures = osmd.sheet.sourceMeasures
    if (sourceMeasures === undefined || measureIndex >= sourceMeasures.length) return
    const measure = sourceMeasures[measureIndex]
    const containers = measure.verticalSourceStaffEntryContainers
    if (containers === undefined || containers.length == 0) return
    forContainer:
    for (let i = containers.length - 1; i >= 0; i--) {
        const staffEntries = containers[i].staffEntries
        if (staffEntries === undefined) continue
        for (let j = 0; j < staffEntries.length; j++) {
            const staffEntry = staffEntries[j]
            if (staffEntry === undefined || staffEntry.instructions === undefined) continue
            const instructions = staffEntry.instructions
            if (instructions === undefined) continue
            for (let k = 0; k < instructions.length; k++) {
                if (instructions[k].clefPitch === undefined) continue
                const clefType = instructions[k].clefType
                const line = instructions[k].line
                if (clefType === undefined || line === undefined) continue
                if (updateClefObj === undefined) updateClefObj = Object()
                const tempClef = Object()
                tempClef.index = j
                tempClef.clefType = clefType
                tempClef.line = line
                if (j == 0 && updateClefObj.rightClef === undefined) {
                    // 右手谱号
                    updateClefObj.rightClef = tempClef
                }
                if (j == 1 && updateClefObj.leftClef === undefined) {
                    // 左手谱号
                    updateClefObj.leftClef = tempClef
                }
                if (updateClefObj.leftClef !== undefined && updateClefObj.rightClef !== undefined) {
                    break forContainer
                }
            }
        }
    }
}

[sschmidTU]

when the clef is in the middle of the bar, I can’t get this information. Is there a related API to get it?

@rianlu In that case, the clef (ClefInstruction/AbstractNotationInstruction) is not in FirstInstructionsStaffEntries, but in another staffentry -> staffentry.Instructions. So, you have to loop over sourceMeasure.VerticalSourceStaffEntryContainers and then over verticalSourceStaffEntryContainer.StaffEntries, which have Instructions, and check if one of these is a KeyInstruction.