Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
How to extend based on OpenTracing.Contrib.NetCore?
See original GitHub issueHello , Thanks for the great work.
I want to add some extensions to OpenTracing.Contrib.NetCore, but some classes like DiagnosticListenerObserver are defined as internal, why isn’t it set to be public ? Is there something I have missed？
Another question, I saw the response of issue 12. I think there is no problem to change the project to netstandard2.0. We are a new library, don’t need to think about the compatibility of .NET Framework. If set to netcoreapp2.0, it is very unfriendly for projects that need to extend OpenTracing.Contrib.NetCore.
Issue Analytics
- State:
- Created 5 years ago
- Reactions:1
- Comments:6
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Hi @cwe1ss,
I have similar case. I want to create DiagnosticListenerObserver for Npgsql events (NpqSql). Another option is implement in this library, but reference to Npgsql isn’t good practice. From my perspective better will be separate library (e.g. OpenTracing.Contrib.NetCore.Npqsql) with implementation for npqsql. I can implement this library, but I need to have DiagnosticListenerObserver and related classes marked as public.
What do you think about this?
Hi, I also want to create DiagnosticListenerObserver for my own EventBus. If the internal class
DiagnosticListenerObserverchange to public will help me a lot. What’s the progress of this issue?