Adding getter of operationName to Span

In my case, I need begin span in one method conditionally, and close it in another method, before close it I need check current active span is the previous one, using ThreadLocal to store span is not a graceful way, I prefer to check span name (make sure unique by application).

private static final String SPAN_NAME = "SOME_SPAN_NAME";

public void preAction() {
	boolean shouldBegin = true; // conditional
	if (shouldBegin) {
		Tracer tracer = GlobalTracer.get();
		if (tracer.activeSpan() != null) {
			Span span = tracer.buildSpan(SPAN_NAME).start();
			tracer.scopeManager().activate(span, true);
		}
	}
}

public void postAction() {
	Scope scope = GlobalTracer.get().scopeManager().active();
	if (scope != null) {
		Span span = scope.span();
		if (SPAN_NAME.equals(span.operationName())) {
			scope.close();
		}
	}
}

My workaround using BaggageItem:

private static final String SPAN_NAME = "SOME_SPAN_NAME";
private static final String BAGGAGE_NAME = "SOME_BAGGAGE_NAME";

public void preAction() {
	boolean shouldBegin = true; // conditional
	if (shouldBegin) {
		Tracer tracer = GlobalTracer.get();
		if (tracer.activeSpan() != null) {
			Span span = tracer.buildSpan(SPAN_NAME).start();
			span.setBaggageItem(BAGGAGE_NAME, "true");
			tracer.scopeManager().activate(span, true);
		}
	}
}

public void postAction() {
	Scope scope = GlobalTracer.get().scopeManager().active();
	if (scope != null) {
		Span span = scope.span();
		if ("true".equals(span.getBaggageItem(BAGGAGE_NAME))) {
			span.setBaggageItem(BAGGAGE_NAME, null); // Should we have an method removeBaggageItem ?
			scope.close();
		}
	}
}

[yurishkuro]

It was absolutely a conscious decision, Span API is write-only. Allowing getters on the span puts additional constraints on the implementors, and we have not yet seen a valid use case where getters would be necessary.

[felixbarny]

Related: https://github.com/opentracing/opentracing-java/issues/57