question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Traced annotation

See original GitHub issue

I’d like to host a @Traced annotation in this repository. Being part of the official API would remove this annotation from specific “downstream” repositories, such as:

opentracing-contrib/java-cdi eclipse/microprofile-opentracing

It could also be used here: https://github.com/opentracing-contrib/java-spring-cloud/issues/98

cc @ledor473, @pavolloffay

Issue Analytics

  • State:open
  • Created 5 years ago
  • Reactions:1
  • Comments:10 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
ledor473commented, Sep 13, 2018

So here’s the context and from where that idea came:

When I was looking at instrumenting code via an agent I found this: https://github.com/DataDog/dd-trace-java/blob/master/dd-trace-api/src/main/java/datadog/trace/api/Trace.java

DD provides a small (no dependency) artifact that can be added to pretty much anything without risking to bring a new version of a library and cause a classpath hell.

That would let the user use a common annotation, while picking its own AOP solution. I felt it would be interesting to have that inside OpenTracing, because if we add it inside the Spring library and I’d like to use it with something non-Spring related, it fells wrong.

0reactions
wuyupengwoainicommented, Nov 5, 2018

I am a normal developer and I think @Traced annotation is a very useful function and the same to other developers using opentracing.But adding @Traced annotation to opentracing is not a good choice.Instead,adding @Traced annotation to java-spring-cloud is a good choice.Futhermore, adding new tags to the existing span is also necessary,beacuse it offers a way to bind the trace to the User-defined tags like mobile or orderId and so on.

As for adding a new annotation or adding new method to the @Traced, i am confused.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Traced (MicroProfile 2.0.1-SNAPSHOT API)
Annotation Type Traced ... This annotation allows fine-tuned control over which classes and methods create OpenTracing spans. By default, all JAX-RS methods ...
Read more >
opentracing-contrib/java-spring-cloud - Traced annotation
I was wondering if it was ever discuss to have a @Traced method-level annotation? It would allow to easily start/stop a span around...
Read more >
Java agent API: Instrument using annotation
Annotating a method with @Trace tells the Java agent that measurements should be taken for that method. To add a method call as...
Read more >
Enabling explicit distributed tracing code instrumentation - IBM
Use the @Traced annotation to instrument classes and methods for OpenTracing. ... Apply the @Traced annotation to specify a class or method to...
Read more >
Trace (newrelic-api 7.11.0 API)
If you annotate a method with the Trace annotation it will be automatically timed by the New Relic agent with the following measurements:....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found