question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Span does not set error tag if `__exit__` is called with an exception

See original GitHub issue

It seems like we’d want to do the following if a span is closed exceptionally, given that we’re already logging the exception to the span:

def __exit__(self, exc_type, exc_val, exc_tb):
    if exc_type:
        self.set_tag(tags.ERROR, True)
    ...

If others agree I can open a PR

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:13 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
carlosalbertocommented, Jan 8, 2019

Closing this one via #101

1reaction
yurishkurocommented, Jul 11, 2018

+1

Read more comments on GitHub >

github_iconTop Results From Across the Web

Is there a way to bypass <span class=""> and get this data ...
I tried finding this element by class and by tag name. It just returns an error. Is it possible to scrape the data...
Read more >
Best practices for custom tracing - IBM
Marking a span with an error​​ Spans that represent work that contained an error, such as an exception, should include the error and...
Read more >
Advanced Usage — ddtrace documentation - Read the Docs
This class takes as argument a list of regular expression patterns representing the urls to be excluded from tracing. A trace will be...
Read more >
Model validation in ASP.NET Core MVC | Microsoft Learn
Here are some of the built-in validation attributes: ... When applied to a Name property, the error message created by the preceding code ......
Read more >
Rules & Actions · inspectIT Ocelot Documentation
As the name states, we define under the entry property of the rule which actions are performed on method entry. Similarly, the exit...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found