Some fonts causes load error "already has key" with Safari

Loading MuseoSans300Italic.otf or BrandonText_Medium.otf causes the entriesToObject method to crash.

Current Behavior

entriesToObject, in Safari seems to fail if it gets an entries list with numbered keys out of order. Eg.

entries = 
[
[0, [380]],
[1, [647]],
[1200, [648]],
[2, [649]]
]

will crash when trying to add key = 2 (last in array). It seems like Safari has an error that when adding o[1200]= [648], it also adds o[2] = NaN. This causes o.hasOwnProperty(key) to trigger an error.

Possible Solution

Is the o.hasOwnProperty(key) test necessary? Can it be expanded to do o.hasOwnProperty(key) && !isNaN(o[key])? Both work for the font I’ve encountered problems with.

Your Environment

• Version used: 0.6.9
• Font used: MuseoSans300Italic.otf, BrandonText_Medium.otf
• Browser Name and version: Safari 10.1
• Operating System and version (desktop or mobile): Macos 10.12.4

[neiltron]

I’m also seeing this issue in Safari using Regina Black. It seems to be happening when calling opentype.load twice on the same font (though I’ve only seen it happen with this one font). @casperno’s proposed fix works for me.

Edit: I submitted a preemptive PR in case you decide this is an acceptable solution.

[fdb]

I was on holiday in the last weeks. I just fixed this, and release 0.7.3, which contains the fix, should appear on npm soon.