One byte missed when uploading upgrade image file

I am working on OpenWRT-19.07 branch. I have my device working with 19.07.

We got device failed to boot with image built today, caused by incorrect image file been flashed to device.

We found this only happened with Chrome and the “keep settings” option off. And the image file save to /tmp in device only missed one byte:

	local fp
	local fp_len = 0
	http.setfilehandler(
		function(meta, chunk, eof)
			if not fp and meta and meta.name == "image" then
				fp = io.open(image_tmp, "w")
				fp_len = 0
			end
			if fp and chunk then
				fp_len = fp_len + string.len(chunk)
				fp:write(chunk)
			end
			if fp and eof then
				os.execute("echo file length: "..fp_len.." > /dev/console")
				fp:close()
			end
		end
	)

file length: 18021887
file length: 18021888

*Tested with Chrome in both Windows 7 & Debian testing, both have this issue

• FireFox & IE have no such issue.
• “Keep settings” must be unchecked to reproduce this bug
• Wireshark says the file length posted by Chrome is 18021888 when bug happens

[hnyman]

Thanks. This seems to fix things.

I compiled and tested the new version both with 18.06 and master. I sysupgraded with this from 18.06 to master with the same image that was problematic yesterday, and then tested the new version also in master for further sysupgrades. Seems to be ok also there.

A bit sad that the old version is in 18.06.4 images. That may be problematic in sysupgrading to the next release to 19.07. Once the buildbot has compiled the fixed version of lucihttp, you might maybe add this as a “known issues” section in the 18.06.4 release notes.

[srdgame]

will test it 😃